Repository navigation
[access] refactor(independence): hide the K25 controllers, BSN format, push channels and context-chat listener behind their components - #7503
Conversation
…analytics-series controllers Both controllers were hand-wired in BuiltinIntegrationServices, the only file outside lib/Controller that named them. Their dependencies are all container-resolvable (the service interfaces are bound in ContractBindings), so the hand-wired entries go and the controllers autowire like every other controller. AnalyticsSeriesController takes the app id from AppIdentity instead of receiving it. Assisted-by: ClaudeCode:claude-opus-5-5
NlPatternSet in lib/Files was the only file outside lib/Formats that named BsnFormat. It now types the check as Opis' Format and gets the default from IdentifierFormats, a factory inside lib/Formats. Assisted-by: ClaudeCode:claude-opus-5-5
…xt-chat listener inside their components NotifyPushListener now reads the channel names from the PushChannels interface (PushEvents implements it, so PushEvents::OR_OBJECT keeps working). The context-chat content-provider listener is registered by ContextChatRegistrar, which FlowsListenerRegistrar calls at the same point, so the listener order is unchanged. Assisted-by: ClaudeCode:claude-opus-5-5
Assisted-by: ClaudeCode:claude-opus-5-5
|
Newman API Test Suite (api-test-coverage) is red, but not because of this PR.
I have asked GitHub to re-run the job once. There is no fix to bring in from here: the failure appears to come from how the full suite runs in CI, since these tests pass when run on their own. Generated by Claude Code |
|
Two more red checks, and neither comes from this PR: This PR changes only PHP files under
There is no fix to bring into this PR. Both checks need fixing on Generated by Claude Code |
|
Two more frontend checks are red, and neither comes from this PR:
There is no fix to bring into this PR. Both checks need fixing on Generated by Claude Code |
|
Another red check that doesn't come from this PR: Generated by Claude Code |
|
I also ran phpstan locally on every file this PR touches, and it found no errors. There is no fix to bring into this PR. Generated by Claude Code |
|
There is no fix to bring into this PR. Generated by Claude Code |
|
Each one reports code this PR does not add or change:
There is no fix to bring into this PR. Generated by Claude Code |
|
Neither finding affects behaviour. Everything else phpmd reports is in code this PR doesn't touch, so the check will stay red until Generated by Claude Code |
|
This PR changes only container wiring for I found no other run of this job to compare against: none of the 15 most recent completed runs of this workflow on other branches included it. There is no fix for these three that belongs in this PR. Generated by Claude Code |
|
They are in Separately, the run reports 4,354 risky tests: tests that execute code their
The first is a missing Generated by Claude Code |
Quality Report — ConductionNL/openregister @
|
| Check | PHP | Vue | Security | License | Tests |
|---|---|---|---|---|---|
| lint | ✅ | ||||
| phpcs | ❌ | ||||
| phpmd | ❌ | ||||
| psalm | ❌ | ||||
| phpstan | ❌ | ||||
| phpmetrics | ✅ | ||||
| eslint | ❌ | ||||
| stylelint | ✅ | ||||
| build | ✅ | ||||
| check-specs | ✅ | ||||
| test-l10n | ❌ | ||||
| test-l10n-parity | ❌ | ||||
| format | ❌ | ||||
| check-schema-l10n | ✅ | ||||
| test-coverage-ratchet | ✅ | ||||
| composer | ✅ | ✅ 168/168 | |||
| npm | ✅ | ✅ 641/641 | |||
| app:check-code | ⏭️ | ||||
| info.xml | ✅ | ||||
| REUSE | ✅ | ||||
| lockfile sync | ✅ | ||||
| PHPUnit | ❌ 49038/49048 · 19 skipped | ||||
| Newman | ❌ 1625/1628 | ||||
| Playwright | ⏭️ deferred: E2E runs locally and on the promotion path only. This pull request targets development, so the suite is asked once per promotion into beta and main rather than once per push per open pull request. Run it locally with npx playwright test, or from the Actions tab on a branch with no open pull request into development. |
||||
| Hydra gates | ❌ |
Quality workflow — 2026-11-09 12:06 UTC
Download the full PDF report from the workflow artifacts.
Lane K25, round 10c: component independence for the K25 classes. The interfacing targets were already met at the start (over-4 params 9, target 9; over-6 params 0, target 0).
What changed
BuiltinIntegrationServicesare gone, and the container now autowires both controllers. Their service dependencies were already typed against interfaces bound inContractBindings, so each resolves to the same shared service instance.AnalyticsSeriesControllernow takes its app id fromAppIdentity::APP_ID(brief step 2). The factory-table tests lose those two entries.NlPatternSetnow types the elfproef as Opis'Format. Its default instance comes fromIdentifierFormats::bsn(), a new factory inside lib/Formats.new NlPatternSet()behaves as before.PushChannels.PushEventsimplements it, soPushEvents::OR_OBJECTandPushEvents::OR_COLLECTIONstill work.NotifyPushListenerreadsPushChannels.ContextChatRegistrar::registerListeners()registers it now.FlowsListenerRegistrarcalls that method at the same point, so the pinned listener order is unchanged (ListenerOrderTestpasses against the unchanged fixture).K25InterfaceBindingsTestandIdentifierFormatsTest.What ran (on this branch merged with current origin/development)
@specwarnings that remain were already there before this change.Numbers (lane_measure.py, lane K25)
Left
DestructionRefusedException::__construct(5 params): it is built in lib/Service/Deletion/RetentionClockService.php, which is in open [access] refactor(db): reach the purpose, share, report and flow-claim mappers through narrow interfaces #6965.AI disclosure: this change was made by Claude Code (an AI coding assistant) running as an automated lane.
Generated by Claude Code